Use proxy-agent instead of superagent-proxy #5042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaboopeeter
force-pushed
the
remove-superagent-proxy
branch
from
bb7a387
to
3a17d2a
Compare
|
This solution is not complete, I'm not sure how I missed this - apparently the npm commands I ran to build/watch this were not building what I expected. Will close this for now, and re-open if I have time to clean it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proxy-agent instead of superagent-proxy to get rid of vm2
Resolves: #5035, resolves: #5030, resolves: #4921
vm2is a deprecated package with critical security issues.For details see:
@ionic-clihasvm2in its dependency tree via[email protected]There has been multiple issues and PRs in
superagent-proxyabout this. See TooTallNate/superagent-proxy#50 for example. But even after months, no solution has been taken in their repo. Which prompted many of the consumers of this library to just cutsuperagent-proxyand fall back toproxy-agent.One such examples is Microsoft's appcenter-cli, whose approach I followed. Refer to for details on their corresponding PR: microsoft/appcenter-cli#2387
Note:
proxy-agenthas already gotten rid ofvm2as a dependency: TooTallNate/proxy-agents#224Test results
Tested the change locally by:
HTTPS_PROXYenv variable to a local proxy instance (Charles Proxy)See below:
